Project

General

Profile

Change Request #3891

Remove FOCUSer from master

Added by Johannes Eder 4 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Hackathon
Start date:
12/09/2019
Due date:
% Done:

0%

Estimated time:

Description

As mira will be removed, most of the process checks are no longer valid. Due to this fact FOCUSer shall be removed.


Related issues

Related to Support #3469: Cleanup Constraint metamodelNew07/04/2018

Related to Feature #3865: Make model loader more tolerant regarding unknown typesClosed11/05/2019

History

#1 Updated by Johannes Eder 4 months ago

#2 Updated by Johannes Eder 4 months ago

  • Related to Feature #3865: Make model loader more tolerant regarding unknown types added

#3 Updated by Simon Barner 4 months ago

We have to check that this branch fixes the following error when loading the ACC model:

!ENTRY org.eclipse.core.jobs 4 2 2019-12-20 16:19:09.860
!MESSAGE An internal error occurred during: "Model Constraint Checker Job".
!STACK 0
java.lang.UnsupportedOperationException
    at org.fortiss.af3.mira.model.impl.AnalysisImpl.getDefinitionElement(AnalysisImpl.java:555)
    at org.fortiss.af3.project.utils.FunctionScopeUtils.getFunctionDefinition(FunctionScopeUtils.java:55)
    at org.fortiss.af3.expression.language.TypeChecker.typecheckUserdefinedFunction(TypeChecker.java:308)
    at org.fortiss.af3.expression.language.TypeChecker.typecheckExpression(TypeChecker.java:165)
    at org.fortiss.af3.expression.language.TypeChecker.typecheck(TypeChecker.java:93)
    at org.fortiss.af3.component.constraint.ComponentConstraintChecker.performTypeCheck(ComponentConstraintChecker.java:105)
    at org.fortiss.af3.component.constraint.ComponentConstraintChecker.performPortCheck(ComponentConstraintChecker.java:86)
    at org.fortiss.af3.component.constraint.ComponentConstraintChecker.collectViolations(ComponentConstraintChecker.java:57)
    at org.fortiss.af3.component.constraint.ComponentConstraintChecker.collectViolations(ComponentConstraintChecker.java:1)
    at org.fortiss.tooling.kernel.extension.base.MultiViolationConstraintCheckerBase.apply(MultiViolationConstraintCheckerBase.java:44)
    at org.fortiss.tooling.kernel.internal.ConstraintCheckerService.performConstraintCheck(ConstraintCheckerService.java:125)
    at org.fortiss.tooling.kernel.internal.ConstraintCheckerService.performAllConstraintChecksRecursively(ConstraintCheckerService.java:94)
    at org.fortiss.tooling.kernel.ui.internal.MarkerService.refreshMarkers(MarkerService.java:196)
    at org.fortiss.tooling.kernel.ui.internal.MarkerService$2.run(MarkerService.java:115)
    at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

#4 Updated by Simon Barner 3 months ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Johannes Eder to Simon Barner

For review.

#5 Updated by Simon Barner 3 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Simon Barner to Johannes Eder

Review done. Please review the following changes to fix the above problem, and re-assign to me.

  • org.fortiss.tooling.kernel.utils.ResourceUtils: now YELLOW
  • In mira.ecore, I had to remove the org.fortiss.af3.project.model.typesystem.IFunctionScope interface from org.fortiss.af3.mira.model.Analysis. Now RED (as before)

#6 Updated by Johannes Eder 3 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Johannes Eder to Simon Barner

Review done.

  • ResourceUtils GREEN
  • mira.ecore stays red as discussed

#7 Updated by Simon Barner 3 months ago

  • Assignee changed from Simon Barner to Johannes Eder

Merged, please close.

#8 Updated by Johannes Eder 3 months ago

  • Status changed from Resolved to Closed
  • Assignee deleted (Johannes Eder)

Also available in: Atom PDF