Clean up use of SWT Display and Shells
Problems
-
Display.getCurrent()
and `Display.getDefault()* are used arbitrarily. This is a potential source for the effect that dialogs are displayed not on the same screen as AF3.- `Shell@ s are created on the fly, resulting into spurious windows being created (e.g., displayed in behind dialogues). Partially addressed in #3840.
Suggested changes:
- Everywhere
MessageUtilsExtended
to raise error/warning/info/question dialogs in order to centralize their creation - Possibly introduce util methods to obtain a
Display
or aShell
, and to run code in a UI context (wrapper forDisplay.(a)syncExec()
)
(from redmine: issue id 3842, created on 2019-10-09, closed on 2019-12-20)