Project

General

Profile

Change Request #3712

Extend image export functionality from component architectures only to task and platform architectures

Added by Tiziano Munaro over 1 year ago. Updated 5 months ago.

Status:
Feedback
Priority:
Normal
Category:
-
Start date:
04/15/2019
Due date:
% Done:

70%

Estimated time:

Description

Description

Extend the functionality defined in eu.fbk.af3.tools.diagram.ui.commands.AbstractComponentToImage.export(String saveFilePath, Component component) to support task and platform architectures as well - ideally through a generic implementation.

Expected behavior

The "Export component as image ..." feature shall behave exactly the same as for the component architectures, allowing the export of the architectures with their respective layouts.

3712.af3_23 (18.2 KB) 3712.af3_23 Simon Barner, 05/02/2019 10:26 AM
3712.png (21.1 KB) 3712.png Simon Barner, 05/02/2019 10:26 AM

Related issues

Related to Feature #2679: [safety-reporting] Build an exporter for safety casesClosed02/05/2019

History

#1 Updated by Tiziano Munaro over 1 year ago

  • Status changed from New to Feedback
  • Assignee changed from Tiziano Munaro to Alexander Diewald
  • % Done changed from 0 to 80

#2 Updated by Simon Barner over 1 year ago

I reviewed the code.

Furthermore, I identified the following issues / suggested changes:

  1. Existing image files are overwritten without asking!
  2. There is lots of excessive white space around the exported images. Not ideal for reusing the image in a document.
  3. Connector labels sometimes overlap with model element labels. Maybe this is related to the "Automatic port label layout" feature? Since we now have an autolayouter at the diagram level, I suggest to consider to remove that feature. In my opinion, the layout of exported images should just mirror what is displayed in the tool.
  4. In case a name label does not fit the bounding box of the model element, in the diagram viewer the name is abbreviated ("Component" -> "Com..." in the attached model). However, in the exported image, the label is currently not abbreviated. This should be implemented, ideally reusing the code for the diagram viewer for the image export.
  5. af3.safetycases.ui contains a clone of the image export
    • However, in that exporter, the element labels in the exported images are customized and differ from those in the diagram view.
    • In order to get rid of that clone, e.g. the IModelElementHandler interface should be extended with a method (e.g., getPrintLabel()) that enables such customizations. The default implementation of that method (in ModelElementHandlerBase) should simply call getName()).
    • This activity should be synchronized with #2679
  6. The generated images are black and white. It would be good to set the foreground and background color of the model elements according the edit parts getForegroundColor() and getBackgroundColor() return values. This activity should be synchronized with #2679.

#3 Updated by Simon Barner over 1 year ago

  • Related to Feature #2679: [safety-reporting] Build an exporter for safety cases added

#4 Updated by Simon Barner over 1 year ago

Just as a hint: the 3712 branches have been merged with master. Please pull before you continue...

#5 Updated by Tiziano Munaro 12 months ago

  • Target version changed from AF3 2.16 RC1 (Feature Freeze) to AF3 2.17 (Feature Freeze)

#6 Updated by Johannes Eder 5 months ago

  • Target version changed from AF3 2.17 (Feature Freeze) to AF3 2.18 - Feature Freeze

Also available in: Atom PDF