Project

General

Profile

Change Request #3365

Commonize ExplorationTargets

Added by Alexander Diewald over 2 years ago. Updated 4 months ago.

Status:
Closed
Priority:
High
Assignee:
-
Category:
-
Start date:
04/03/2018
Due date:
% Done:

100%

Estimated time:
2.00 h

Description

Current Status.

The Objective/Constraint editors of the DSE perspective are using the eclass "SMTObjective/-Constraint" to construct DSML expressions. These eclasses are located in the ...exploration.smt plugin, which requires other DSE plugins to depend on this plugin if they shall be able to parse DSML expressions. This breaks the intended architecture of the exploration plugins.

Proposed Change.

Introduce two "generic" eclasses in the "org.fortiss.af3.exploration" plugin, or transform the existing ExplorationObjective/-Constraint from interfaces to instantiatable classes. Then, use these classes in the DSE editors.
Nevertheless, it is still possible to have plugin-specific specializations of the ExplorationObjectives/-Constraints, but the DSML expressions created in the perspective would be passed by the common Exploration Targets.


Related issues

Precedes Bug #4022: Creation of safety level constraint throws exceptionResolved04/04/201804/04/2018

History

#1 Updated by Alexander Diewald over 1 year ago

  • Target version changed from AF3 2.14 RC1 (Feature Freeze) to AF3 2.15 RC1 (Feature Freeze)

#2 Updated by Johannes Eder over 1 year ago

  • Target version changed from AF3 2.15 RC1 (Feature Freeze) to AF3 2.16 RC1 (Feature Freeze)

#3 Updated by Alexander Diewald about 1 year ago

  • Priority changed from Normal to High
  • Target version changed from AF3 2.16 RC1 (Feature Freeze) to AF3 2.16 RC2 (Tested, Bug-free)

#4 Updated by Alexander Diewald 12 months ago

  • Target version changed from AF3 2.16 RC2 (Tested, Bug-free) to AF3 2.17 (Feature Freeze)

#5 Updated by Alexander Diewald 6 months ago

  • Target version changed from AF3 2.17 (Feature Freeze) to AF3 2.18 - Feature Freeze

#6 Updated by Alexander Diewald 5 months ago

  • Blocks Bug #4021: Broken Routes from the bus minimization / the bus minimization objective does not reduce the number of routes over busses if the objective is defined for one bus added

#7 Updated by Alexander Diewald 5 months ago

  • Status changed from New to Resolved
  • Assignee changed from Alexander Diewald to Johannes Eder
  • % Done changed from 0 to 100
MRs:

@Johannes: Could you please review this one? It is a prerequisite for one of the issues to be resolved for HUBCAP and is already some time "overdue". Moreover, it is needed to properly resolve #4022, otherwise we can get a lot of conflicts.

If you do not have time, please reassign to me and I will look for someone else.

For testing, please load the ACC example, test the constraint and objective creation and check that the DSE generates solutions. That should be sufficient.

For the review, please note that I removed "sub-ExplorationTargets" as they are not used and not fully implemented. Only the "implict Constraints" for Objectives are still there since they are needed by the bandwidth minimization Objective and I currently see no other clean way to generate supporting constraints for objectives.

#8 Updated by Alexander Diewald 5 months ago

  • Blocks deleted (Bug #4021: Broken Routes from the bus minimization / the bus minimization objective does not reduce the number of routes over busses if the objective is defined for one bus)

#9 Updated by Alexander Diewald 5 months ago

  • Precedes Bug #4022: Creation of safety level constraint throws exception added

#10 Updated by Johannes Eder 5 months ago

@Alex: Ok, no problem. I will review that one.

#11 Updated by Alexander Diewald 4 months ago

Merged. Thanks for the review! Can be closed :)

#12 Updated by Johannes Eder 4 months ago

  • Status changed from Resolved to Closed
  • Assignee deleted (Johannes Eder)

Also available in: Atom PDF