Project

General

Profile

Support #2855

Support #2983: Code Review - collection issue

[code review] exploration(.ui)

Added by Alexander Diewald over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Category:
-
Start date:
02/21/2017
Due date:
% Done:

100%

Estimated time:

Description

Tracking ticket.

History

#1 Updated by Alexander Diewald over 3 years ago

  • Assignee changed from Alexander Diewald to Johannes Eder

- Could you please have a look at ArithmeticStaticImpl: I made two return statements a bit more readable by introducing some boolean variables (methods at line 127 & 142). Please double-check.
- DSLUtils is red now. I think that firstLetterLowerCase will throw a NPE if the string is null. Maybe consider it in the iniitial if.

#2 Updated by Johannes Eder over 3 years ago

  • Assignee changed from Johannes Eder to Alexander Diewald
  • Priority changed from High to Normal

#3 Updated by Alexander Diewald over 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

All green.

#4 Updated by Anonymous over 3 years ago

  • Parent task set to #2983

Also available in: Atom PDF