Project

General

Profile

Support #2419

[Code review] generated GUI-related code should not be could reviewed

Added by Anonymous about 5 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Start date:
08/20/2015
Due date:
% Done:

100%

Estimated time:

Description

This is issue is not really an issue per se. It is intended to be referred to in classes which are dealing with GUI but have been generated by the Google GUI plugin. Code reviewing this is difficult and actually pointless: a new programmer would probably have no difficulty understanding the code simply by running the application. We then consider it acceptable not to review this code as long as this issue is referred to in the class.

History

#1 Updated by Anonymous about 5 years ago

  • Target version changed from AF3 2.8 Release (code reviewed, documented) to AF3 2.9 Release

#2 Updated by Anonymous over 4 years ago

  • Target version changed from AF3 2.9 Release to AF3 2.9 Post-release

#3 Updated by Anonymous over 4 years ago

  • Target version changed from AF3 2.9 Post-release to AF3 2.10 Documented, code reviewed, tested

#4 Updated by Anonymous about 4 years ago

  • Assignee changed from Anonymous to Florian Hölzl

#5 Updated by Florian Hölzl about 4 years ago

  • Target version changed from AF3 2.10 Documented, code reviewed, tested to AF3 2.11 GUI Improvement Week

#6 Updated by Florian Hölzl almost 4 years ago

  • Status changed from New to Resolved
  • Assignee changed from Florian Hölzl to Anonymous

Now, the Developer Installation wiki entry states to include the "**/*GUI.java" pattern as ConQAT exclusion pattern.

#7 Updated by Anonymous almost 4 years ago

Maybe also add in the coding guidelines (https://af3-developer.fortiss.org/projects/autofocus3/wiki/Check-list_for_Code_Reviews) that generated GUI-related code should then always be called ...GUI.java? Or is it done automatically by this GUI generator tool?

#8 Updated by Anonymous almost 4 years ago

  • Assignee changed from Anonymous to Florian Hölzl

#9 Updated by Anonymous almost 4 years ago

  • Target version changed from AF3 2.11 GUI Improvement Week to AF3 2.12 RC3 (Documented, code reviewed, tested)

#10 Updated by Florian Hölzl over 3 years ago

  • Status changed from Resolved to Closed
  • Assignee deleted (Florian Hölzl)
  • % Done changed from 0 to 100

Also available in: Atom PDF