Project

General

Profile

Feature #3791

Ease the DSE solution converter handling

Added by Alexander Diewald about 1 year ago. Updated 11 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Start date:
08/07/2019
Due date:
% Done:

100%

Estimated time:
10.00 h

Description

Current status.

The DSE soulution converter is hard to use: It is unclear when to use the copy operation, very specific utility methods have to be used, hidden dependencies between converters are easily introduced.

Proposed simlifications.

  • Replace the many input parameters of the transform(...) call with a single POJO. This object can then encapsulate the existing utility methods to enforce a defined fetching strategy. Moreover, the copy logic of objects might be abstractable there.
  • Evaluate whether the CopyRefMap could be used more extensively: Copies created within a transformator are recorded there. Thus, they could be reused to fetch child artifacts of primary atrifacts. Nevertheless, this option has to be carefully analyzed w.r.t. to the above point, since child elements are already present there.
  • Copying all inputs incl. input ModelSnapshots may be alternative to operate on copies that crossreference each other correctly from the beginning.
3791-test1-2.PNG (29.9 KB) 3791-test1-2.PNG Error with test 1 and 2 Simon Barner, 11/04/2019 04:30 PM
3791-test3.txt (9.46 KB) 3791-test3.txt Error with test 3 Simon Barner, 11/04/2019 04:30 PM

History

#1 Updated by Alexander Diewald 12 months ago

  • Target version changed from AF3 2.16 RC1 (Feature Freeze) to AF3 2.17 (Feature Freeze)

#2 Updated by Alexander Diewald 11 months ago

  • Priority changed from Normal to High

#3 Updated by Alexander Diewald 11 months ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Done.

Testing instructions:
  • Load the ACC model.
  • Load the model in the DSE Perspective.
    1. Do a deployment synthesis, export, save, restart, ensure the model is still loadable, remove the model.
    2. Do a joint deployment synthesis, export, save, restart, ensure the model is still loadable, remove the model.
    3. Do a deployment synthesis, select the solution, do a schedule synthesis, export, save, restart, ensure the model is still loadable, remove the model.

#5 Updated by Alexander Diewald 11 months ago

  • Assignee changed from Alexander Diewald to Simon Barner

#6 Updated by Simon Barner 11 months ago

  • With tests 1 and 2, the exported data dictionary had a 'null' name (see attached screenshot)
  • With test 3, the export of the schedule resulted into an exception (see attached txt file)

#7 Updated by Alexander Diewald 11 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Alexander Diewald to Simon Barner

Feedback is implemented. Please test again :)

#8 Updated by Simon Barner 11 months ago

  • Status changed from Resolved to Closed
  • Assignee deleted (Simon Barner)
  • Priority changed from High to Normal

Tested OK & merged, thanks!

Also available in: Atom PDF