Project

General

Profile

Change Request #3593

Add an IExpression parser base class

Added by Alexander Diewald almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Start date:
12/13/2018
Due date:
% Done:

100%

Estimated time:
2.00 h

Description

Current status.

We have an IExpressionVisitor interface that defines visit methods to parse DSML IExpressions in conjunction with the accept methods of IExpressions. Due to the absence of a base class that does NOT perform evaluations but simply visits each part of the expression, defining new visitors (parsers) is cumbersome.

Propsoed solution.

Define a base class that implements each visit method and delegates to sub-expressions. That way single, specific visit methods can be overridden.

ACCv3-hier3-Simon3.af3_23 (635 KB) ACCv3-hier3-Simon3.af3_23 Alexander Diewald, 12/14/2018 10:36 AM
ACCv3-good.af3_23 (726 KB) ACCv3-good.af3_23 Alexander Diewald, 12/18/2018 04:14 PM

History

#1 Updated by Alexander Diewald almost 2 years ago

https://git.fortiss.org/af3/af3/merge_requests/142

--> One additional class, one changed Eop

To test, please clone the plugin from https://git.fortiss.org/af3/exploration-alg.git Branch: 3593

Test:
  • Import the attached model and load the DSE in the perspective.
  • Go to the Depl. Synth. & Select the first and third rule set.
  • Test is successfull if the DSE Deloyment Synthesis starts and passes the 10% progress mark.

#2 Updated by Johannes Eder almost 2 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Johannes Eder to Alexander Diewald

Works with moea based exploration. Selecting the smt backend throws a nullpointer (possibly due to missing "basic deployment constraints"). If this is not in the scope of this issue, testing was successful.

#3 Updated by Alexander Diewald almost 2 years ago

Test model with generic architecture.

#4 Updated by Johannes Eder almost 2 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Alexander Diewald to Anonymous

Everyhting works as expected now.

#5 Updated by Johannes Eder almost 2 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Anonymous to Alexander Diewald

Alex, could you please set the newly created/updated classes to yellow such that I can do the review. At least ExpressionParserBase is still red.

#6 Updated by Alexander Diewald almost 2 years ago

  • Assignee changed from Alexander Diewald to Johannes Eder

Done. Please note the comment in the YELLOW commit why there are still deprecation warnings. Those are justified to be kept for now and will be removed before the release definitely.

#7 Updated by Anonymous almost 2 years ago

  • Status changed from Feedback to Resolved

#8 Updated by Anonymous almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF