Project

General

Profile

Change Request #2566

KISS: ObjectAware2ServiceBase and ObjectAwareServiceBase to inherit from IIntrospectiveKernelService

Added by Simon Barner over 4 years ago. Updated over 1 year ago.

Status:
In Progress
Priority:
Low
Category:
-
Target version:
Start date:
04/29/2016
Due date:
07/04/2016
% Done:

90%

Estimated time:
0.50 h

Description

ObjectAware2ServiceBase and ObjectAwareServiceBase to inherit from IIntrospectiveKernelService and implement

public boolean showInIntrospectionNavigation() {
return true;
}

public Collection<IIntrospectionItem> getIntrospectionItems() {
return Collections.emptyList();
}

public IIntrospectionDetailsItem getDetailsItem() {
return null;
}
</p>

Consequence:
* All services are listed in KISS.
* For new services that are based on of these base classes, the developer is reminded / forces to provide a documentation in form implementing the methods returning the label and the description.

History

#1 Updated by Florian Hölzl over 4 years ago

  • Assignee set to Florian Hölzl
  • Target version changed from AF3 2.10 Feature Freeze to TK 2 Release 10 Maintenance and Improvement
  • Estimated time set to 0.50 h

#2 Updated by Florian Hölzl over 4 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 60

The kernel classes have been updated and all AF3 services as well.
However, some services are not yet registered with KISS, since this
triggered the problem of obscure initialization sequences of plugins.

I will continue here as soon as Issue #2590 is resolved.

#3 Updated by Florian Hölzl about 4 years ago

  • Due date set to 07/04/2016
  • Target version changed from TK 2 Release 10 Maintenance and Improvement to TK2 Release 10

#4 Updated by Florian Hölzl about 4 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 60 to 90

All services have been connected to KISS.

#5 Updated by Simon Barner about 4 years ago

  • Status changed from Resolved to Feedback
The following two parts of the description used by many (but not all) services could be shifted to KISSViewPart.updateWidgets() in order to reduce code duplication and enforce a consistent content of the service description field.
  • getIntrospectionLabel()
  • The service extension point is '" + EXTENSION_POINT_NAME + "'."; (this would require to make getExtensionPointName() public

This is only a suggestion, feel free to close the ticket in any case.

Example taken from ModelElementHandlerService:

    /** {@inheritDoc} */
    @Override
    public String getIntrospectionDescription() {
        return getIntrospectionLabel() +
                "\n\nThis service provides the user interface wrappers for model elements." +
                "\nThe navigator service uses the handlers to build the hierarchiy model structure" +
                "\nas well as the display labels and icons." +
                "\n\nThe service extension point is '" + EXTENSION_POINT_NAME + "'.";
    }

#6 Updated by Florian Hölzl about 4 years ago

  • Status changed from Feedback to In Progress
  • Target version changed from TK2 Release 10 to TK 2 Release 10 Maintenance and Improvement

Since the kernel is now feature frozen for TK Release 10 and reviews are commencing,
this issue is moved to the maintenance phase of the release.

#7 Updated by Florian Hölzl over 2 years ago

  • Category set to Hackathon
  • Target version changed from TK 2 Release 10 Maintenance and Improvement to AF3 2.13 RC1 (Feature Freeze)

I will examine this issue in the upcoming hackathon.

#8 Updated by Florian Hölzl over 2 years ago

  • Category deleted (Hackathon)
  • Target version changed from AF3 2.13 RC1 (Feature Freeze) to AF3 2.14 RC1 (Feature Freeze)

#9 Updated by Johannes Eder over 1 year ago

  • Target version changed from AF3 2.14 RC1 (Feature Freeze) to Backlog

Also available in: Atom PDF