Project

General

Profile

Change Request #2234

Refactor compositors to allow state-based implementation of canConnect() / connect() etc.

Added by Simon Barner over 5 years ago. Updated over 2 years ago.

Status:
New
Priority:
Normal
Category:
-
Target version:
Start date:
01/27/2015
Due date:
% Done:

0%

Estimated time:

Description

  • Currently, many methods of compositors that are meant to be overridden (such as canConnect(), canConnectInterally(), connect()) are stateless, i.e. do not into account the current source and target model elements.
  • Hence, the following base classes have potentially dangerous work-arounds using protected fields that are only valid in a given call scope
    • HierarchicElementConnectorConnectionCompositorBase
      • source
      • target
      • updateSourceTarget()
    • PlatformElementConnectionCompositorBase
      • source
      • target
      • updateSourceTarget()
  • Instead of using fields, it would be much safer to extend the interface of the respective methods (connect(), canConnect()) accordingly

History

#1 Updated by Anonymous about 5 years ago

  • Target version changed from AF3 2.8 RC1 (Feature Freeze) to AF3 2.8 RC2 (Tested & Bugfixed)

#2 Updated by Anonymous about 5 years ago

  • Assignee set to Anonymous

#3 Updated by Anonymous about 5 years ago

  • Target version changed from AF3 2.8 RC2 (Tested & Bugfixed) to AF3 2.8 Post-release

#4 Updated by Anonymous about 5 years ago

  • Priority changed from Normal to High

#5 Updated by Anonymous almost 5 years ago

  • Priority changed from High to Normal

#6 Updated by Anonymous almost 5 years ago

  • Target version changed from AF3 2.8 Post-release to AF3 2.9 RC1 (Features frozen)

#7 Updated by Anonymous over 4 years ago

  • Target version changed from AF3 2.9 RC1 (Features frozen) to AF3 2.9 Post-release

#8 Updated by Johannes Eder about 4 years ago

  • Target version changed from AF3 2.9 Post-release to AF3 2.10 Feature Freeze

#9 Updated by Anonymous about 4 years ago

  • Priority changed from Normal to High
  • Target version changed from AF3 2.10 Feature Freeze to AF3 2.10 Post-release

#10 Updated by Anonymous over 3 years ago

  • Target version changed from AF3 2.10 Post-release to AF3 2.11 Post-release

#11 Updated by Anonymous over 2 years ago

  • Target version changed from AF3 2.11 Post-release to AF3 2.13 RC1 (Feature Freeze)

#12 Updated by Anonymous over 2 years ago

  • Assignee changed from Anonymous to Simon Barner

@Simon: is it that important? We managed to live without for a while. Maybe should now just be a requirement for SystemFOCUS no?

#13 Updated by Simon Barner over 2 years ago

  • Assignee changed from Simon Barner to Anonymous

Yes, using this as a SystemFOCUS requirement is absolutely fine.

#14 Updated by Anonymous over 2 years ago

  • Assignee changed from Anonymous to Florian Hölzl
  • Priority changed from High to Normal
  • Target version changed from AF3 2.13 RC1 (Feature Freeze) to AF4 Requirements

@Flo: SystemFocus requirement

Also available in: Atom PDF